gh-92356: Fix regression in ctypes function call overhead#92357
Merged
JelleZijlstra merged 1 commit intopython:mainfrom May 6, 2022
Merged
gh-92356: Fix regression in ctypes function call overhead#92357JelleZijlstra merged 1 commit intopython:mainfrom
JelleZijlstra merged 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
38f331d introduced a delayed initialization routine to set up ctypes formattable (`_ctypes_init_fielddesc`), but inadvertently removed setting the `initialization` flag to 1 to avoid initting each time.
mdboom
force-pushed
the
fix-ctypes_init_fielddesc
branch
from
27b4aeb to
9486b1e
Compare
Member
|
Nice find! |
AlexWaygood
added
topic-ctypes
type-bug
JelleZijlstra
approved these changes
May 6, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Good catch!
I wonder if this initialization will give us thread safety problems for subinterpreters and/or nogil. Seems like it would have data races.
rhettinger
approved these changes
May 6, 2022
Member
|
Thanks, Mike! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
38f331d introduced a delayed initialization routine to set up
ctypes formattable (
_ctypes_init_fielddesc), but inadvertentlyremoved setting the
initializationflag to 1 to avoid inittingeach time.
Cc: @tiran
#92356